-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair contribute links #214
base: master
Are you sure you want to change the base?
Conversation
- link to chameleon repository instead of broken eosdesignsystem - remove icons link as information about icons is provided in the aforementioned repository Signed-off-by: Georg Pfuetzenreuter <[email protected]>
@@ -293,12 +293,9 @@ <h1 lang="en">Contribute Hardware</h1> | |||
<div class="design-system"> | |||
<h3 class="strong-title wow fadeInDown" lang="en">openSUSE Design System</h3> | |||
<h4 class="strong-title wow fadeInDown" data-wow-delay=".5s" lang="en">We've created a Design System to help you contribute consistent web tools and features using the openSUSE colors, writing guides, and more. Check it out:</h4> | |||
<a href="http://opensuse.eosdesignsystem.com/" target="_blank" class="btn btn-default wow zoomIn"> | |||
<a href="https://github.com/openSUSE/chameleon" target="_blank" class="btn btn-default wow zoomIn"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's kind of hard to say if this, or the more generic branding guidelines would be a better fit here. https://opensuse.github.io/branding-guidelines/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the input, didn't know that page was a thing - I think these branding guidelines would be a good fit if they contained a reference to the repository, or did I miss one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That page is newer than the brand guidelines, so that's why they were never included. I would ask @kwwii if maybe we could include a link in there.
Does this belong on the landing page at all? We should have some mention of how to use our logos and brand around the page (neither eos or the brand guidelines do this strangely enough), but I think it would be a better fit in the footer or maybe some subpage? For subpages to happen we would likely need to have a more solid revamp. Contribute section is for something like https://contribute.opensuse.org |
Another page I never knew of... :-) I think that one would be better indeed, covering a wider range of contribution options. But albeit it being a nice idea, I'm not sure everyone wants to go through a session of questioning - maybe there should be a general list of options as well. |
We had a request for that, it will happen whenever I have the time to focus on that |
Signed-off-by: Georg Pfuetzenreuter [email protected]